Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config transformers and filters now error if no matches #1577

Merged
merged 3 commits into from
Jun 21, 2021

Conversation

matthchr
Copy link
Member

What this PR does / why we need it:

  • Ensure that all config transformers and filters
    raise an error by default if they don't match anything.
  • Removed config options that had no matches.

  - Ensure that all config transformers and filters
    raise an error by default if they don't match anything.
  - Removed config options that had no matches.
@matthchr
Copy link
Member Author

I got tired of fighting with it for VMSS (where I'm mucking with the config quite a bit to make sure the resource comes out looking good).

@matthchr matthchr added this to the codegen-alpha-0 milestone Jun 21, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1577 (69f2ed7) into master (90631f0) will decrease coverage by 0.09%.
The diff coverage is 48.93%.

❗ Current head 69f2ed7 differs from pull request most recent head 0e9b222. Consider uploading reports for the commit 0e9b222 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1577      +/-   ##
==========================================
- Coverage   63.57%   63.48%   -0.10%     
==========================================
  Files         182      182              
  Lines       11856    11876      +20     
==========================================
+ Hits         7537     7539       +2     
- Misses       3650     3669      +19     
+ Partials      669      668       -1     
Impacted Files Coverage Δ
hack/generator/pkg/codegen/pipeline_load_schema.go 10.20% <0.00%> (-1.43%) ⬇️
hack/generator/pkg/config/configuration.go 32.70% <23.07%> (-1.29%) ⬇️
...or/pkg/codegen/pipeline_apply_property_rewrites.go 75.00% <33.33%> (-9.62%) ⬇️
...rator/pkg/codegen/pipeline_apply_export_filters.go 68.00% <50.00%> (+1.33%) ⬆️
hack/generator/pkg/config/type_matcher.go 68.62% <78.94%> (-2.11%) ⬇️
hack/generator/pkg/config/type_transformer.go 89.18% <100.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90631f0...0e9b222. Read the comment docs.

@matthchr matthchr merged commit 0e4cd9c into Azure:master Jun 21, 2021
@matthchr matthchr deleted the feature/config-errors branch June 21, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants