Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplication of parameter name assignment #1589

Merged
merged 2 commits into from
Jun 24, 2021

Conversation

theunrepentantgeek
Copy link
Member

@theunrepentantgeek theunrepentantgeek commented Jun 22, 2021

What this PR does / why we need it:

We had the parameter name for the PropertyAssignmentFunction defined in two places, which would allow them to inadvertently move out of sync later on. This PR centralises the naming of the parameter into one place, caching the name on the function to allow easy reuse where required.

Closes #1564

How does this PR make you feel:
gif

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2021

Codecov Report

Merging #1589 (de3709c) into master (3d5e5a3) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head de3709c differs from pull request most recent head 3a9e234. Consider uploading reports for the commit 3a9e234 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1589      +/-   ##
==========================================
- Coverage   63.25%   63.24%   -0.02%     
==========================================
  Files         183      183              
  Lines       11918    11914       -4     
==========================================
- Hits         7539     7535       -4     
  Misses       3706     3706              
  Partials      673      673              
Impacted Files Coverage Δ
...or/pkg/conversions/property_assignment_function.go 74.01% <100.00%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d5e5a3...3a9e234. Read the comment docs.

@matthchr matthchr merged commit c2e7189 into master Jun 24, 2021
@matthchr matthchr deleted the fix/duplicate-parameter-names branch June 24, 2021 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicate hard coding of source and destination
4 participants