Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Storage Conversion generation bug #1595

Merged

Conversation

matthchr
Copy link
Member

@matthchr matthchr commented Jun 23, 2021

If a map type is a TypeName that is not pointing to a local package, just use the type as is rather than trying to look it up (which will fail).

  - If a map type is a TypeName that is not pointing to a local package,
    just use the type as is rather than trying to look it up (which will
    fail).
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2021

Codecov Report

Merging #1595 (1f1ae37) into master (d420499) will increase coverage by 0.02%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1595      +/-   ##
==========================================
+ Coverage   63.22%   63.25%   +0.02%     
==========================================
  Files         183      183              
  Lines       11903    11918      +15     
==========================================
+ Hits         7526     7539      +13     
- Misses       3704     3706       +2     
  Partials      673      673              
Impacted Files Coverage Δ
...enerator/pkg/codegen/storage/property_converter.go 0.00% <0.00%> (ø)
hack/generator/pkg/astbuilder/builder.go 85.09% <100.00%> (+0.37%) ⬆️
hack/generator/pkg/astmodel/type_name.go 63.49% <100.00%> (+3.14%) ⬆️
.../generator/pkg/conversions/property_conversions.go 78.68% <100.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d420499...1f1ae37. Read the comment docs.

@matthchr
Copy link
Member Author

Thanks @theunrepentantgeek for the push to the branch with additional tests and some extra fixes

@matthchr matthchr merged commit 20a468e into Azure:master Jun 24, 2021
@matthchr matthchr deleted the feature/storage-version-nonlocal-types branch June 24, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants