Fix: TypeWalker aborting on TypeNames from external packages #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
babbageclunk,
davefellows,
matthchr and
Porges
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1599 +/- ##
==========================================
- Coverage 63.27% 63.26% -0.02%
==========================================
Files 184 184
Lines 11924 11926 +2
==========================================
Hits 7545 7545
- Misses 3706 3707 +1
- Partials 673 674 +1
Continue to review full report at Codecov.
|
matthchr
approved these changes
Jun 24, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We use
TypeNamereferences to external types, but theTypeWalkerwas aborting when it encountered them. Fix is to stop walking when a non-local package is found.How does this PR make you feel:
