Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for V2 VMSS #1603

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Add support for V2 VMSS #1603

merged 1 commit into from
Jun 28, 2021

Conversation

matthchr
Copy link
Member

What this PR does / why we need it:

  • Add support for a code generated version of VMSS
  • Add tests for VMSS.

If applicable:

  • this PR contains tests

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2021

Codecov Report

Merging #1603 (09d1906) into master (c2e7189) will increase coverage by 0.02%.
The diff coverage is 50.00%.

❗ Current head 09d1906 differs from pull request most recent head 1779efc. Consider uploading reports for the commit 1779efc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1603      +/-   ##
==========================================
+ Coverage   63.24%   63.27%   +0.02%     
==========================================
  Files         183      183              
  Lines       11914    11928      +14     
==========================================
+ Hits         7535     7547      +12     
+ Misses       3706     3705       -1     
- Partials      673      676       +3     
Impacted Files Coverage Δ
...ted/pkg/reconcilers/azure_deployment_reconciler.go 56.07% <ø> (ø)
...d/pkg/testcommon/error_translating_roundtripper.go 13.33% <0.00%> (+0.83%) ⬆️
hack/generated/pkg/testcommon/test_context.go 58.55% <57.89%> (+0.66%) ⬆️
.../generated/pkg/testcommon/kube_per_test_context.go 79.66% <0.00%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e7189...1779efc. Read the comment docs.

Copy link
Member

@babbageclunk babbageclunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Comment on lines 195 to 197
},
},
},
},
},
},
},
},
},
},
},
},
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whee!

@matthchr matthchr merged commit 0b5e1f2 into Azure:master Jun 28, 2021
@matthchr matthchr deleted the feature/vmss branch June 28, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants