Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document our issue triage process #1610

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Conversation

theunrepentantgeek
Copy link
Member

What this PR does / why we need it:

Makes our goal for issue triage public, and documents the GitHub search that we use.

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation

@codecov-commenter
Copy link

Codecov Report

Merging #1610 (a5c9d91) into master (0b5e1f2) will not change coverage.
The diff coverage is n/a.

❗ Current head a5c9d91 differs from pull request most recent head 38079a4. Consider uploading reports for the commit 38079a4 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1610   +/-   ##
=======================================
  Coverage   62.38%   62.38%           
=======================================
  Files         186      186           
  Lines       12273    12273           
=======================================
  Hits         7656     7656           
  Misses       3926     3926           
  Partials      691      691           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b5e1f2...38079a4. Read the comment docs.

@@ -0,0 +1,10 @@
# Issue Triage

On a regular basis (target: weekly) the development team will triage issues matching the following [GitHub search](https://github.com/Azure/azure-service-operator/issues?q=is%3Aissue+is%3Aopen+-label%3Atriaged+no%3Amilestone+):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, you could rephrase this as:

Suggested change
On a regular basis (target: weekly) the development team will triage issues matching the following [GitHub search](https://github.com/Azure/azure-service-operator/issues?q=is%3Aissue+is%3Aopen+-label%3Atriaged+no%3Amilestone+):
On a regular basis (target: weekly) the development team will triage issues matching the following search criteria [is:issue is:open -label:triaged no:milestone](https://github.com/Azure/azure-service-operator/issues?q=is%3Aissue+is%3Aopen+-label%3Atriaged+no%3Amilestone+)

and do away entirely with the ``` section below

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks a bit cleaner in that it turns the issue criteria into the link rather than having a separate "this search" link

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally wrote it the way you suggest - but broke it out the way that I did so that the search criteria was more explicitly called out for people to see. Makes it easier to copy too.

@theunrepentantgeek theunrepentantgeek merged commit e16e429 into master Jun 29, 2021
@theunrepentantgeek theunrepentantgeek deleted the doc/issue-triage branch June 29, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants