Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tparallel linter and fix #1638

Merged
merged 2 commits into from
Jul 11, 2021
Merged

Add tparallel linter and fix #1638

merged 2 commits into from
Jul 11, 2021

Conversation

Porges
Copy link
Member

@Porges Porges commented Jul 9, 2021

If subtests are going to run in parallel the parent test needs to be marked as well; this linter catches it.

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2021

Codecov Report

Merging #1638 (04a8c97) into master (81091cf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1638   +/-   ##
=======================================
  Coverage   66.63%   66.63%           
=======================================
  Files         204      204           
  Lines       14760    14760           
=======================================
  Hits         9835     9835           
  Misses       4169     4169           
  Partials      756      756           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81091cf...04a8c97. Read the comment docs.

Copy link
Member

@theunrepentantgeek theunrepentantgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. #shipit

Rocket Launch

@theunrepentantgeek
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Porges Porges merged commit 744f90b into master Jul 11, 2021
@Porges Porges deleted the linters branch July 11, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants