Use Update (PUT) not Patch when modifying spec and status #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
babbageclunk,
davefellows,
Porges and
theunrepentantgeek
as code owners
matthchr
force-pushed
the
feature/put-not-patch
branch
from
b7c017a
to
03c3375
Compare
|
Note: There are lots more refactors that we need to do to |
matthchr
commented
Jul 30, 2021
PATCHing means that we don't know for sure the state of the resource after the PATCH (because it might have been a different version than we thought). PATCHing also makes removal of fields difficult, which is especially important in places like Status where there's no telling what can come or go from reconcile loop iteration N to iteration N+1.
It's significantly more complex than we need for our use case
matthchr
force-pushed
the
feature/put-not-patch
branch
from
03c3375
to
96c7052
Compare
Codecov Report
@@ Coverage Diff @@
## master #1674 +/- ##
==========================================
- Coverage 67.98% 67.98% -0.01%
==========================================
Files 212 210 -2
Lines 15151 15076 -75
==========================================
- Hits 10300 10249 -51
+ Misses 4082 4069 -13
+ Partials 769 758 -11
Continue to review full report at Codecov.
|
theunrepentantgeek
pushed a commit
that referenced
this pull request
Aug 6, 2021
* Use PUT not PATCH for all k8s resource updates PATCHing means that we don't know for sure the state of the resource after the PATCH (because it might have been a different version than we thought). PATCHing also makes removal of fields difficult, which is especially important in places like Status where there's no telling what can come or go from reconcile loop iteration N to iteration N+1. * Remove util/patch It's significantly more complex than we need for our use case
theunrepentantgeek
pushed a commit
that referenced
this pull request
Aug 11, 2021
* Use PUT not PATCH for all k8s resource updates PATCHing means that we don't know for sure the state of the resource after the PATCH (because it might have been a different version than we thought). PATCHing also makes removal of fields difficult, which is especially important in places like Status where there's no telling what can come or go from reconcile loop iteration N to iteration N+1. * Remove util/patch It's significantly more complex than we need for our use case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Patch has a number of issues:
Rather than fight with Patch, moved to use Update (full replace) everywhere. As part of this work also refactored a little to make the controller more deterministic.
How does this PR make you feel:
If applicable: