Force top level status properties to be optional #1694
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There are times when
Status
doesn't exist, such as when an object is first created. There's a bit of an unwritten rule that:Status
is not a pointer on the resource.omitempty
set.This way when there isn't a status, there's not a bunch of extra
""
's returned.This is especially important for some multi-write cases between spec and status, as
""
's returned can overwrite in-memory data before it has a chance to be sent via aclient.Status().Update()
callHow does this PR make you feel: