Fix issues in Azure SQL branch #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* improve tests with parallel execution and rm sleep * fix the tests to run on kindcluster
* feat: implement keyvault controller * Ace's KV changes with updates * Added an event for the final successful provisioning * Updated changes based on the PR comments * removing unwanted file * making resource group name the one in the keyvault yaml Co-authored-by: Ace Eldeib <alexeldeib@gmail.com>
* this needs to exist in the reconciler in order to use controllerutil createorupdate
* add consumer group kind * update tests for consumer group * fix isbeingdeleted
* cluster additions * updated docs
* Update azure-pipelines.yaml
* revert back // +kubebuilder:subresource:status changes - fix broken tests
* add dev conatiner - wip * DevContainer up and running. * Removed `sleep 80` and replaced with `kubectl wait`. * Run `make set-kindcluster` from docker-compose. * Set timeout on wait. * Added `install-test-dependency` to makefile and dockerfile. * Update README - Create SP with contribution rights. * Updated README with details on using devcontainer. * Stuff that wanted me to commit. * Reverted changes made to `docker-build` in Makefile.
* first commit on Amanda's branch * first * before properties * test not tested * test works * unit tests work, needs firewall rules * addresses feedback * erin's feedback * janani's change, pass future * async works much better now * janani feedback * screwed up interface prototype
* Updated eventhub_types - Added `secretName`. * Added `secretName` to sample manifest. * Set secret name to `secretName` if set, otherwise use eventhub name. * Updated Makefile to update Azure Operator. Also added the ability to rebuild image without cache. * Updated README on how to update the Azure Operator. * Updated CRD with SecretName description. * Added tests to ensure `SecretName` was being used if present. * Fix test.
…erator into azuresqlsrvtest
Please enter the commit message for your changes. Lines starting
…erator into azuresqlsrvtest
…erator into azuresqlsrvtest
…erator into azuresqlsrvtest
…d of config and the error library. Please enter the commit message for your changes. Lines starting
Porges
pushed a commit
that referenced
this pull request
May 11, 2021
* Add StripUnusedDefinitions pass to CodeGenerator.Generate Update expected output to remove unreferenced types in the expected output for AllOf_generates_wrapper_type * Add Referees method to Type and impls The name is awkward - it might be better to replace References with this. * Implement collecting referrers (I think) * Implement the connectedness check If a definition isn't connected by a series of references to any root definition (ie, a resource) then it should be filtered out. Memoised to save checking a type name twice. * Correct implementation of TypeName.Referees Originally implementation was based on a misunderstanding of how the different astmodel types worked. * Strip unused definitions in jsonast golden tests This required moving StripUnusedDefinitions out of pkg/codegen - I put it into pkg/astmodel because that's where all of the types it interacts with are. Also enabled passing in a different set of roots, since the golden tests use the Test type (which isn't a resource) as the root. * Update Type.References to return a TypeNameSet, remove Referees Returning a set makes the old behaviour simple to implement in the few places that used it. Adds a SetUnion to combine two TypeNameSets. I thought about making this a method to add all of the elements of another set to the receiver - it would be more efficient but I think it's less clean. * Don't memoise negative checkWithPath results These can come from a search that is unwinding because it detected a cycle, rather than one that didn't find a root. In that case we can't know whether a search from this node with a different path would succeed. Added a unit test to explore this problem. Made the TypeNameSet methods take TypeNames rather than *TypeNames - this simplified them a bit (at the cost of having to do some extra nil checks at the edges). * Corrected grammar on doc comments * Simplify connectedness-check thanks to a suggestion from Matt Rather than walking up the references until we find a root, walk down the references from the roots collecting up all of the types we reach. This is much simpler and doesn't need any memoisation (since the accumulated set replaces it). * Update Function.References to match Type.References * Remove unnecessary nil checks These *TypeNames can't be nil - there are a lot of earlier points in the code that do no-look dereferences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Special notes for your reviewer:
If applicable: