Suppress classes causing test failures #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
babbageclunk,
davefellows,
matthchr and
Porges
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1724 +/- ##
==========================================
+ Coverage 71.06% 71.09% +0.02%
==========================================
Files 226 226
Lines 16016 16036 +20
==========================================
+ Hits 11381 11400 +19
- Misses 3810 3811 +1
Partials 825 825
Continue to review full report at Codecov.
|
Porges
approved these changes
Aug 17, 2021
matthchr
approved these changes
Aug 17, 2021
matthchr
reviewed
Aug 17, 2021
| return false | ||
| } | ||
|
|
||
| // Check for types that we need to suppress - these are ARM types that don't currently round trip because they're |
There was a problem hiding this comment.
Might make sense to put this comment by the specific classes suppressions, and not here in the generic suppression handling?
There was a problem hiding this comment.
In case there are other reasons for suppression that aren't due to OneOf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A very small number of ARM State classes representing OneOf conditions can't currently round trip as they override marshaling to JSON without overriding marshaling from JSON (See #1721 #1722)
We want to revisit these and fix things up as a part of implementing diff'ing (#1366), so I took a very simple approach to suppressing the test failures.
Also included, some improvements to the way the output of property tests is formatted (the default uses a 75 column wordwrap which is a bit narrow for our use).
How does this PR make you feel:
