Update kind #1738
Merged
Update kind #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
babbageclunk,
davefellows and
Porges
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1738 +/- ##
=======================================
Coverage 70.96% 70.96%
=======================================
Files 227 227
Lines 16135 16135
=======================================
Hits 11450 11450
Misses 3850 3850
Partials 835 835
Continue to review full report at Codecov.
|
matthchr
force-pushed
the
feature/kind-update
branch
from
28fe32f
to
ce79979
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The one we have is a bit old and I think has a bug where sometimes nodes won't start? The new one at least works for me consistently.
Also deleted the makefiles in hack because we don't use them for anything anymore.