Reduce test polling speed some to reduce flakiness #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
babbageclunk,
davefellows,
Porges and
theunrepentantgeek
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1745 +/- ##
=======================================
Coverage 70.96% 70.96%
=======================================
Files 227 227
Lines 16135 16135
=======================================
Hits 11450 11450
Misses 3850 3850
Partials 835 835
Continue to review full report at Codecov.
|
theunrepentantgeek
approved these changes
Aug 24, 2021
| // TODO: updating resource: Operation cannot be fulfilled: the object has been modified; please apply your changes to the latest version and try again. | ||
| // TODO: This happens when the test sees a Status update and makes an update to the resource while racing with the Spec update | ||
| // TODO: in azure_deployment_reconciler CommitUpdate. If we fix https://github.com/Azure/azure-service-operator/issues/1744 we can reduce this | ||
| // TODO: further. |
There was a problem hiding this comment.
Minor ambiguity - does "reduce this further" mean "reduce the time between polling" or "reduce how often we poll"?
matthchr
force-pushed
the
feature/test-fixes
branch
from
fbe27c9
to
46ecb5d
Compare
matthchr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obivously this isn't the ideal way to do things, but I can't think of another "easy" fix. The real solution is to stop modifying status and spec at the same time, but I believe in order to do that we need to move some fields out of Spec and into Status, which will take some effort. This should unblock us for now.