Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reconcile predicates to prevent reconcile on status update #1752

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

matthchr
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2021

Codecov Report

Merging #1752 (d6d1c4a) into master (6917a6e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d6d1c4a differs from pull request most recent head 3b877db. Consider uploading reports for the commit 3b877db to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1752      +/-   ##
==========================================
- Coverage   42.12%   42.11%   -0.01%     
==========================================
  Files         309      309              
  Lines       89872    89876       +4     
==========================================
- Hits        37856    37855       -1     
- Misses      48694    48696       +2     
- Partials     3322     3325       +3     
Impacted Files Coverage Δ
hack/generated/controllers/generic_controller.go 78.18% <100.00%> (+0.20%) ⬆️
...ted/pkg/reconcilers/azure_deployment_reconciler.go 68.51% <100.00%> (-0.24%) ⬇️
hack/generator/pkg/astmodel/package_reference.go 88.28% <0.00%> (-2.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6917a6e...3b877db. Read the comment docs.

@matthchr matthchr force-pushed the feature/reconcile-predicates branch from c70b53e to d6d1c4a Compare August 26, 2021 20:31
@matthchr matthchr force-pushed the feature/reconcile-predicates branch from d6d1c4a to 3b877db Compare August 26, 2021 20:33
@matthchr matthchr merged commit cfb25c0 into Azure:master Aug 26, 2021
@matthchr matthchr deleted the feature/reconcile-predicates branch August 26, 2021 20:49
Copy link
Member

@theunrepentantgeek theunrepentantgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants