-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check Name Availability/Validation for SQL Resources #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frodopwns
reviewed
Sep 30, 2019
frodopwns
reviewed
Sep 30, 2019
frodopwns
reviewed
Sep 30, 2019
Fixed those three @frodopwns ! Thanks for that. Lemme know if there is anything else you think could be better/needs fixing. |
jananivMS
approved these changes
Oct 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for the minor comment
Porges
pushed a commit
that referenced
this pull request
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Fixes
Addresses issue #214
PR Adds the following:
servername is invalid
Running the test:
make run
sqlserver1.2
in the file: config/samples/azure_v1_sqlserver.yamlkubectl create -f config/samples/azure_v1_sqlserver.yaml file
Should get an error in the first terminal for:
DEBUG controller-runtime.manager.events Warning {"object": {"kind":"SqlServer","namespace":"default","name":"sqlserver1.2","uid":"9311940d-e168-11e9-b1dc-5a2bc381628e","apiVersion":"azure.microsoft.com/v1","resourceVersion":"160697"}, "reason": "Failed", "message": "Servername is invalid"} 2019-09-27T14:51:35.917-0600 INFO controllers.SqlServer Specified server name contains unsupported characters or is too long. Server name must be no longer than 63 characters long, contain only lower-case characters or digits, cannot contain '.' or '_' characters and can't start or end with '-' character. {"sqlserver": "default/sqlserver1.2"} 2019-09-27T14:51:35.917-0600 INFO controllers.SqlServer Servername is invalid {"sqlserver": "default/sqlserver1.2"} 2019-09-27T14:51:35.917-0600 ERROR controller-runtime.controller Reconciler error {"controller": "sqlserver", "request": "default/sqlserver1.2", "error": "Servername invalid sqlserver1.2"}
kubectl describe sqlserver sqlserver1.2
, should get:Controller successfully errors out, and
If applicable: