replace hard coded http status code #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porges
pushed a commit
that referenced
this pull request
May 11, 2021
* Add BaseType() to EnumType and improve test coverage * Add WithoutValidation() to PropertyDefinition and test * Create pipeline stage for creating storage types and test * Exclude storage generation from golden tests * Update TypeVisitor for StorageType * Add ApplyObjectTransformation() to TypeDefinition and test * Add ApplyObjectTransformations() to TypeDefinition and test * Extend default visitor to avoid rewrapping ArmTypes * Add predicates to Types Where a TypeName is passed, the definition will be looked up, recursively. Also includes related methods IsArmDefinition() and IsArmResource(). * Refactor Pipeline step for creating ARM types * Modify ArmType to implement Type with pointer receiver * Code gardening * Fix compilation errors in tests * Use predicates to identify ARM resources * Add IsResourceDefinition() predicate * Modify getReceiverObjectType() to unwrap ArmType * Defensive logging in pipeline * Fix errors references * Modify how ReferenceGraph detects ArmSpec and ArmStatus types * Add AsResourceType() conversion method * Fix tests * Address lint issues * Fix issue with TypeVisitor * Remove obsolete test * Renaming for clarity * Change predicate to conversion method ResolveEnumDefinition() * Eliminate nil case for StorageType * Add missing docComments * Simplify implementation of ApplyObjectTransformations() * Return error instead of panicing * Fix visiting of StorageType to accommodate more transformations * Removed unused IsArm*() methods * Use accessor method Type() instead of directly accessing the member * Clarify comment about defensive cloning * Remove blank line * Remove commented code * Reformat parameter wrapping * Change return type to `TypeName` * Update for PackageReference interface use * Rename method to mapTypeNameIntoStoragePackage for clarity * Add pipeline stage to simplify types * Address PR feedback * Update consumption of PackageReferences * Update comments in reference_graph for clarity * Code gardening * Use propertyConversions to create storage properties * Remove check that's not needed in TypeVisitor * Restore deleted comment * Address issues identified in PR * Use %T to show types in type visitor errors * Rename methods to make declarative use clearer * Remove redundant context call * Apply suggestions from code review Co-authored-by: Christian Muirhead <christian.muirhead@microsoft.com> * Rename method to reflect pointer return * Include index of transformation in error * Code gardening * Fix bug passing wrong context to visitor Co-authored-by: Christian Muirhead <christian.muirhead@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#242
What this PR does / why we need it:
Special notes for your reviewer:
If applicable: