Mark ManagedClusterServicePrincipalProfile.Secret as a secret reference
#3026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
super-harsh
requested review from
davefellows,
theunrepentantgeek,
matthchr and
babbageclunk
as code owners
added 2 commits
May 30, 2023 14:08
Codecov Report
@@ Coverage Diff @@
## main #3026 +/- ##
=======================================
Coverage 54.29% 54.29%
=======================================
Files 1400 1400
Lines 599548 599598 +50
=======================================
+ Hits 325508 325579 +71
+ Misses 220665 220614 -51
- Partials 53375 53405 +30
|
docs/hugo/content/guide/breaking-changes/breaking-changes-v2.1.0.md
Outdated
Show resolved
Hide resolved
….0.md Co-authored-by: Bevan Arps <bevan.arps@microsoft.com>
matthchr
approved these changes
Jun 13, 2023
| @@ -860,6 +860,9 @@ objectModelConfiguration: | |||
| ManagedClusterAgentPoolProfileProperties: | |||
| ProximityPlacementGroupID: | |||
| $armReference: false # This is true in the next version and we have custom conversion to make round-tripping work | |||
| ManagedClusterServicePrincipalProfile: | |||
| Secret: | |||
There was a problem hiding this comment.
We should fix this upstream in the AKS Swagger specifications as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Marked ContainerService/ManagedCluster field
ManagedClusterServicePrincipalProfile.Secretto be a secret reference.