-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export API keys for search service #3065
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good for exposing the keys, but how are you addressing the ARM API shape required for apiKeyOnly
access?
The required ARM payload is this:
"authOptions": {
"apiKeyOnly": {}
}
I don't see any changes to the ARM types or the CRD shape in this PR to address this.
Codecov Report
@@ Coverage Diff @@
## main #3065 +/- ##
========================================
Coverage 54.26% 54.26%
========================================
Files 1399 1400 +1
Lines 599240 599548 +308
========================================
+ Hits 325179 325372 +193
- Misses 220735 220815 +80
- Partials 53326 53361 +35
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
name: searchservicekeyssecret | ||
queryKey: | ||
key: queryKey | ||
name: searchservicekeyssecret |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: should have a newline at the end here
What this PR does / why we need it:
Closes: #3053
Adding the support for exporting API keys for Azure Cognitive Search and reviving the
authOptions
property to enable users to select aadOrApiKey auth mode.Special notes for your reviewer:
Also had to add the custom key matcher logic to replace/hide the base64 keys without '=' padding for the returned API keys
If applicable: