-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify Pre/Post-Reconciliation Extensions to provide a Resolver #3105
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3105 +/- ##
==========================================
+ Coverage 54.23% 54.25% +0.01%
==========================================
Files 1418 1418
Lines 609010 609010
==========================================
+ Hits 330312 330432 +120
+ Misses 224596 224472 -124
- Partials 54102 54106 +4
|
@@ -8,6 +8,7 @@ package customizations | |||
import ( | |||
"context" | |||
"fmt" | |||
"github.com/Azure/azure-service-operator/v2/internal/resolver" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: import ordering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And in other files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
What this PR does / why we need it:
The two extension points
PreReconciliationChecker
andPostReconciliationChecker
provide numerous parameters to enable extension implementations to easily achieve their goals.We passed through a
kubeclient.Client
by design, but have found this to be difficult to consume because our resources often have agenruntime.ResourceReference
butkubeclient.Client
requires a GVK.Replacing
kubeclient.Client
withresolver.Resolver
bridges this gap, allowing extension implementers to simply callResolveReference()
and not fuss with GVK (etc).Closes #3092
How does this PR make you feel: