Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration of FederatedIdentityCredential #3125

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

theunrepentantgeek
Copy link
Member

What this PR does / why we need it:

Allows the issuer and subject properties of FederatedIdentityCredential to be set from configMaps.

Closes #3030

How does this PR make you feel:
gif

@codecov-commenter
Copy link

Codecov Report

Merging #3125 (1646a3a) into main (d505950) will decrease coverage by 0.05%.
The diff coverage is 38.40%.

@@            Coverage Diff             @@
##             main    #3125      +/-   ##
==========================================
- Coverage   54.24%   54.19%   -0.05%     
==========================================
  Files        1418     1418              
  Lines      609010   603516    -5494     
==========================================
- Hits       330350   327104    -3246     
+ Misses     224537   222911    -1626     
+ Partials    54123    53501     -622     
Impacted Files Coverage Δ
...ederated_identity_credential_spec_arm_types_gen.go 33.33% <ø> (ø)
...storage/federated_identity_credential_types_gen.go 55.17% <ø> (-0.39%) ⬇️
...ederated_identity_credential_spec_arm_types_gen.go 33.33% <ø> (ø)
...storage/federated_identity_credential_types_gen.go 40.50% <20.00%> (-3.22%) ⬇️
...preview/federated_identity_credential_types_gen.go 50.00% <25.00%> (-5.36%) ⬇️
...preview/federated_identity_credential_types_gen.go 52.66% <31.81%> (-4.43%) ⬇️
...2/internal/controllers/controller_resources_gen.go 85.60% <80.00%> (-0.10%) ⬇️

... and 152 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Feature: Allow dynamic configuration of FederatedIdentityCredential
3 participants