feat(helm): add support for NetworkPolicies in v2 Helm chart #3164
Conversation
tongpu
requested review from
davefellows,
theunrepentantgeek,
matthchr,
babbageclunk and
super-harsh
as code owners
|
@microsoft-github-policy-service agree company="Adfinis" |
tongpu
force-pushed
the
feat/networkpolicies-v2-chart
branch
from
b765eb0 to
92165f2
Compare
|
@tongpu is this still something you're driving? If not we can probably take it over and get it merged. Let us know. |
I've lost track of it as life was rather busy recently. I'll push the proposed changes by next week the latest. |
tongpu
force-pushed
the
feat/networkpolicies-v2-chart
branch
from
0e0b4df to
291a9a3
Compare
|
@matthchr Thanks for the reminder. I've pushed the remaining changes and I think the PR should be ready now. |
|
/ok-to-test sha=291a9a3 |
| # Destination CIDR for talking to the Kubernetes API | ||
| kubernetesApiCIDR: 0.0.0.0/0 | ||
| # Destination CIDR for talking to MySQL servers | ||
| kubernetesApiCIDR: 0.0.0.0/0 |
There was a problem hiding this comment.
copy/paste error (caught by CI): This should be mysqlCIDR, and the one below postgresqlCIDR
There was a problem hiding this comment.
Fixed. One should not commit on a Friday afternoon.
|
/ok-to-test sha=be6ebf1 |
| protocol: TCP | ||
| to: | ||
| - ipBlock: | ||
| cidr: {{ .Values.networkpolicies.kubernetesApiCIDR }} |
There was a problem hiding this comment.
Ahh, I missed CI was also having issue with networkpolicies vs networkPolicies.
It's supposed to be networkPolicies but a few of these here have a lowercase p
|
/ok-to-test sha=11672eb |
2 similar comments
|
/ok-to-test sha=11672eb |
|
/ok-to-test sha=11672eb |
|
/ok-to-test sha=94ffb6f |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
live mysql test timed out.. retrying |
|
/ok-to-test sha=94ffb6f |
|
Thanks for the contribution @tongpu! |
Closes #3160
What this PR does / why we need it:
Adds support for NetworkPolicies to ASO v2 Helm chart
Special notes for your reviewer:
How does this PR make you feel:
If applicable: