-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redact empty status properties #3180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
matthchr,
babbageclunk and
super-harsh
as code owners
August 4, 2023 02:58
Codecov Report
@@ Coverage Diff @@
## main #3180 +/- ##
==========================================
- Coverage 54.38% 54.37% -0.01%
==========================================
Files 1419 1419
Lines 604182 604177 -5
==========================================
- Hits 328557 328522 -35
- Misses 221948 221969 +21
- Partials 53677 53686 +9
|
matthchr
approved these changes
Aug 4, 2023
@@ -138,3 +141,10 @@ func (*ResourceImportResult) writeTo(resources []genruntime.MetaObject, destinat | |||
|
|||
return nil | |||
} | |||
|
|||
// redact removes any empty `status { }` blocks from the yaml | |||
func redact(data []byte) []byte { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: redactStatus
? Since it doesn't generally redact "other stuff"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When importing an Azure resource, we have been getting an empty status section in the output, which isn't necessary.
This PR redacts that wart to make things cleaner:
Special notes for your reviewer:
Also fixes a minor bug where the output was being sent to the wrong stream, giving weird results on screen.
How does this PR make you feel: