-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add two new labels #3184
Add two new labels #3184
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3184 +/- ##
==========================================
+ Coverage 54.39% 54.40% +0.01%
==========================================
Files 1424 1424
Lines 601364 601364
==========================================
+ Hits 327122 327189 +67
+ Misses 220776 220690 -86
- Partials 53466 53485 +19
|
- Add the app.kubernetes.io/name and app.kubernetes.io/version labels. - Remove serviceoperator.azure.com/version in favor of the standard app.kubernetes.io/version label. - Update taskfile to use new labels in various places. This fixes Azure#3165.
6795e96
to
36d3954
Compare
Would be good to open an issue to remove the old label at some point? |
We can't easily remove the old label because it's being used as a labelSelector for the deployment. Technically speaking, we could use these new labels as selectors and remove the old one, but:
Given that there aren't any other pods in our namespace which use this label, I think it's OK to have this be our label selector and avoid making users do a |
/ok-to-test sha=fe16343 |
/ok-to-test sha=629c452 |
This fixes #3165.
If applicable: