Use fully qualified ARM ID to identity importers #3203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
matthchr,
babbageclunk and
super-harsh
as code owners
super-harsh
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
During import of an Azure Resource, asoctl was using the name of the resource as a unique key to identity the resource.
While these names are often unique (due to the use of GUIDs or to specific naming conventions), they aren't always unique.
In particular, some resources have hard coded names - and when those names collided, asoctl was incorrectly assuming the importers were identical.
One case where this occured was during import of a Storage Account - all of the container resources within a Storage Account (for Blobs, Queues, Tables and Files) are named
default.This PR changes to using the full ARM ID as the unique identifier for each importer.
Fixes #3195
How does this PR make you feel:
