-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new versions of cache RP #3206
Conversation
18ad221
to
03f16df
Compare
/ok-to-test sha=96cb206 |
Codecov Report
@@ Coverage Diff @@
## main #3206 +/- ##
==========================================
+ Coverage 54.39% 54.48% +0.09%
==========================================
Files 1424 1442 +18
Lines 601351 614666 +13315
==========================================
+ Hits 327097 334904 +7807
- Misses 220754 224925 +4171
- Partials 53500 54837 +1337
|
@@ -0,0 +1,19 @@ | |||
apiVersion: cache.azure.com/v1api20230401 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest separating these samples out in their own folders like v1api20230401
and v1api20201201
for consistency with other groups
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not every group does this actually, and because there's a bunch of API versions coexisting (because of redis + redisenterprise) it felt better to put it all into 1 folder like we do for compute so that people don't have to guess which API versions support which resources. Basically I think people are resource-centric and making them choose API versions first doesn't help in sample discovery. It's fine when every resource is in every API version (pick any one and you're right), but in this case not every resource is in every APIversion so it's harder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just a couple minors comments.
5078ee8
to
ff9576d
Compare
/ok-to-test sha=ff9576d |
If applicable: