Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions of ServiceBus #3216

Merged
merged 17 commits into from
Sep 4, 2023
Merged

Conversation

theunrepentantgeek
Copy link
Member

What this PR does / why we need it:

Adds support for ARM API versions 2021-11-01 and 2022-10-01-preview of ServiceBus.

Closes #3143

Special notes for your reviewer:

While only 2022-10-01-preview was requested, including 2021-11-01 makes the conversion graph cleaner and avoids need for some counter-intuitive type renaming in azure-arm.yaml.

How does this PR make you feel:
gif

If applicable:

  • this PR contains tests

@codecov-commenter
Copy link

Codecov Report

Merging #3216 (60709b4) into main (55e6ec8) will increase coverage by 0.16%.
Report is 3 commits behind head on main.
The diff coverage is 61.79%.

@@            Coverage Diff             @@
##             main    #3216      +/-   ##
==========================================
+ Coverage   54.42%   54.59%   +0.16%     
==========================================
  Files        1428     1482      +54     
  Lines      609210   632725   +23515     
==========================================
+ Hits       331582   345427   +13845     
- Misses     223364   230688    +7324     
- Partials    54264    56610    +2346     
Files Changed Coverage Δ
.../servicebus/customizations/namespace_extensions.go 73.21% <ø> (ø)
...ations/namespaces_authorization_rule_extensions.go 51.78% <ø> (ø)
...pi/servicebus/v1api20211101/namespace_types_gen.go 52.04% <ø> (ø)
...icebus/v1api20211101/namespaces_topic_types_gen.go 59.80% <ø> (ø)
...mespaces_topics_subscription_spec_arm_types_gen.go 33.33% <ø> (ø)
...211101/namespaces_topics_subscription_types_gen.go 54.69% <ø> (ø)
...es_topics_subscriptions_rule_spec_arm_types_gen.go 33.33% <ø> (ø)
.../namespaces_topics_subscriptions_rule_types_gen.go 50.21% <ø> (ø)
...icebus/v1api20211101storage/namespace_types_gen.go 55.17% <ø> (ø)
...storage/namespaces_authorization_rule_types_gen.go 55.17% <ø> (ø)
... and 52 more

... and 76 files with indirect coverage changes

Copy link
Collaborator

@super-harsh super-harsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few minor comments.

@theunrepentantgeek theunrepentantgeek enabled auto-merge (squash) September 4, 2023 04:11
@theunrepentantgeek theunrepentantgeek merged commit 17ca060 into main Sep 4, 2023
@theunrepentantgeek theunrepentantgeek deleted the feature/servicebus-update branch September 4, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

TLS version on Azure Service Bus
4 participants