Treat CustomKubeletIdentityMissingPermissionError as retryable #3286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
matthchr,
babbageclunk and
super-harsh
as code owners
Codecov Report
@@ Coverage Diff @@
## main #3286 +/- ##
==========================================
+ Coverage 54.48% 54.52% +0.03%
==========================================
Files 1482 1482
Lines 633430 633443 +13
==========================================
+ Hits 345141 345363 +222
+ Misses 231667 231455 -212
- Partials 56622 56625 +3
|
matthchr
approved these changes
Sep 13, 2023
v2/api/containerservice/customizations/managed_cluster_extensions.go
Outdated
Show resolved
Hide resolved
v2/api/containerservice/customizations/managed_cluster_extensions.go
Outdated
Show resolved
Hide resolved
nibooy
pushed a commit
to nibooy/azure-service-operator
that referenced
this pull request
Sep 22, 2023
…#3286) * Treat CustomKubeletIdentityMissingPermissionError as retryable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Treat the error
CustomKubeletIdentityMissingPermissionErroras a retryable error, to avoid a race condition where slow creation of aUserAssignedIdentitymight cause creation of aManagedClusterto fail with a permanent error.Closes #3267
Special notes for your reviewer:
How does this PR make you feel:
