API Management Service

[ross-p-smith]

Relates to #2747

This PR is the first of ~10 that I will add for API Management. This is the root service and the one that takes ~1.5 hours to complete. It is the base API Management. I don't believe that many people will use an operator to build this purely because of the time it takes to complete. However, it is the gateway to the more interesting parts (routes/apis/backends/products, etc)

How does this PR make you feel:

If applicable:

• this PR contains documentation
• this PR contains tests

[theunrepentantgeek]

This is really solid. I've flagged a few places where properties need some ASO flavouring, nothing that's difficult to do. Ping us if you have problems getting the recording to play nicely. Once that's included, I'll happily approve.

[theunrepentantgeek]

I have had 1 recording complete, but when re-running it fails.

What error do you have when it fails? It's super likely it's a failure mode we've seen before.

[ross-p-smith]

This is really solid. I've flagged a few places where properties need some ASO flavouring, nothing that's difficult to do. Ping us if you have problems getting the recording to play nicely. Once that's included, I'll happily approve.

I've added 2 recordings (1 for the integration and one for samples) - hope that's correct

[ross-p-smith]

The previous run worked (before I merged main). It is failing on ServiceBus at the moment

"validate.v1api20221001preview.namespacesauthorizationrules.servicebus.azure.com" denied the request: at least one of ['ARMID'] or ['Group', 'Kind', 'Namespace', 'Name'] must be set for ResourceReference
[produce-markdown-summary]             {
[produce-markdown-summary]                 ErrStatus: {
[produce-markdown-summary]                     TypeMeta: {Kind: "", APIVersion: ""},
[produce-markdown-summary]                     ListMeta: {
[produce-markdown-summary]                         SelfLink: "",
[produce-markdown-summary]                         ResourceVersion: "",
[produce-markdown-summary]                         Continue: "",
[produce-markdown-summary]                         RemainingItemCount: nil,
[produce-markdown-summary]                     },
[produce-markdown-summary]                     Status: "Failure",
[produce-markdown-summary]                     Message: "admission webhook \"validate.v1api20221001preview.namespacesauthorizationrules.servicebus.azure.com\" denied the request: at least one of ['ARMID'] or ['Group', 'Kind', 'Namespace', 'Name'] must be set for ResourceReference",
[produce-markdown-summary]                     Reason: "Forbidden",
[produce-markdown-summary]                     Details: nil,
[produce-markdown-summary]                     Code: 403,
[produce-markdown-summary]                 },
[produce-markdown-summary]             }
[produce-markdown-summary] --- FAIL: Test_ServiceBus_Namespace_Standard_v1api20221001preview_CRUD/subtests/AuthorizationRule_CRUD (0.02s)

[theunrepentantgeek]

That servicebus error doesn't seem related to your changes. I've merged main so we can see if it recurrs. I'll mention it to the other members of the ASO team to see if they've seen it.

[theunrepentantgeek]

/ok-to-test sha=027aa84

[matthchr]

/ok-to-test sha=e7f9e1c

[theunrepentantgeek]

That servicebus error doesn't seem related to your changes. I've merged main so we can see if it recurrs. I'll mention it to the other members of the ASO team to see if they've seen it.

@matthchr has found and fixed the problem in PR #3373; once you've merged main into your branch things should run smoothly.

[theunrepentantgeek]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[theunrepentantgeek]

Looks good to me!

[matthchr]

Hmm it seems this is still getting exposed as a string?

[matthchr]

Ooh, there's 2 one here and one below.

[matthchr]

Fixed in #3377