Allow to customize webhook server port and cert dir #3442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincepri
requested review from
davefellows,
theunrepentantgeek,
matthchr,
babbageclunk and
super-harsh
as code owners
vincepri
force-pushed
the
openshift-installer
branch
2 times, most recently
from
44cee9a to
1969e0d
Compare
|
@microsoft-github-policy-service agree company="Red Hat" |
Signed-off-by: Vince Prignano <vince@prigna.com>
vincepri
force-pushed
the
openshift-installer
branch
from
1969e0d to
f324202
Compare
|
This seems reasonable to me. |
|
/ok-to-test sha=f324202 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
matthchr
approved these changes
Oct 18, 2023
super-harsh
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
LGTM. The only minor thing I'm thinking of is to make them configurable through our helm chart. Which we can do in a separate PR by resolving #3444
vincepri
added a commit
to vincepri/azure-service-operator
that referenced
this pull request
Oct 19, 2023
Signed-off-by: Vince Prignano <vince@prigna.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #[issue number]
What this PR does / why we need it:
Allows users to customize the port and certificate directory. Aligns with Cluster API flags.
If applicable: