Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Authorization to v2022-04-01 #3504

Merged
merged 10 commits into from
Nov 9, 2023
Merged

Conversation

theunrepentantgeek
Copy link
Member

@theunrepentantgeek theunrepentantgeek commented Nov 6, 2023

What this PR does / why we need it:

Adds support for the latest non-preview version of Authorization

Special notes for your reviewer:

Partial resolution of #3294

Prerequisites

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

@theunrepentantgeek theunrepentantgeek self-assigned this Nov 6, 2023
@theunrepentantgeek theunrepentantgeek changed the base branch from main to update/submodule-2023-11 November 6, 2023 04:20
Base automatically changed from update/submodule-2023-11 to main November 6, 2023 20:22
Copy link
Member

@matthchr matthchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase but I think looks good other than that (can't quite tell because of combination of changes due to submodule update).

v2/azure-arm.yaml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Merging #3504 (636d94e) into main (98b4281) will decrease coverage by 0.03%.
The diff coverage is 55.49%.

@@            Coverage Diff             @@
##             main    #3504      +/-   ##
==========================================
- Coverage   54.04%   54.02%   -0.03%     
==========================================
  Files        1573     1577       +4     
  Lines      656726   657464     +738     
==========================================
+ Hits       354960   355195     +235     
- Misses     244284   244702     +418     
- Partials    57482    57567      +85     
Files Coverage Δ
...tomizations/role_assignment_extension_types_gen.go 100.00% <100.00%> (ø)
...ation/customizations/role_assignment_extensions.go 0.00% <ø> (ø)
...2/internal/controllers/controller_resources_gen.go 83.62% <100.00%> (+0.02%) ⬆️
...rization/v1api20220401/role_assignment_defaults.go 85.71% <85.71%> (ø)
...1api20220401/role_assignment_spec_arm_types_gen.go 33.33% <33.33%> (ø)
.../v1api20200801preview/role_assignment_types_gen.go 58.14% <50.00%> (+3.85%) ⬆️
...0200801previewstorage/role_assignment_types_gen.go 52.96% <50.00%> (+2.19%) ⬆️
.../v1api20220401storage/role_assignment_types_gen.go 47.45% <47.45%> (ø)
...0200801previewstorage/role_assignment_types_gen.go 51.14% <59.72%> (+3.68%) ⬆️
...ization/v1api20220401/role_assignment_types_gen.go 53.40% <53.40%> (ø)

... and 35 files with indirect coverage changes

roleDefinitionReference:
# This ARM ID represents "Contributor" - you can read about other built in roles here: https://docs.microsoft.com/en-us/azure/role-based-access-control/built-in-roles
armId: /subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Authorization/roleDefinitions/b24988ac-6180-42a0-ab88-20f7382dd24c

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: Extra newline here

@matthchr
Copy link
Member

matthchr commented Nov 9, 2023

Looks like this needs to re-run task (or just the generator) locally after the merge of REST capabilities on resources.

@theunrepentantgeek theunrepentantgeek added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit 802fe55 Nov 9, 2023
9 checks passed
@theunrepentantgeek theunrepentantgeek deleted the update/authorization branch November 9, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants