Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax enum requirement for compute VM #3609

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Relax enum requirement for compute VM #3609

merged 1 commit into from
Nov 28, 2023

Conversation

matthchr
Copy link
Member

@matthchr matthchr commented Nov 28, 2023 •
edited
Loading

If applicable:

  • this PR contains documentation
  • this PR contains tests

@matthchr
Relax enum requirement for compute VM
e94c932 
* This requirement is slated to be deprecated in 1 month (I believe
  they are moving to a plain string like VMSS does).
* Fixes 3474.
@matthchr matthchr self-assigned this Nov 28, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a8de8ee) 53.10% compared to head (e94c932) 53.09%.

Files Patch % Lines
...compute/v1api20220301/virtual_machine_types_gen.go 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3609      +/-   ##
==========================================
- Coverage   53.10%   53.09%   -0.02%     
==========================================
  Files        1286     1286              
  Lines      406699   406683      -16     
==========================================
- Hits       215993   215934      -59     
- Misses     159708   159750      +42     
- Partials    30998    30999       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthchr
Copy link
Member Author

/ok-to-test sha=e94c932

@matthchr matthchr added this pull request to the merge queue Nov 28, 2023
Merged via the queue into Azure:main with commit b1307e1 Nov 28, 2023
8 checks passed
@matthchr matthchr deleted the feature/vm-enum-relax branch November 28, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theunrepentantgeek theunrepentantgeek theunrepentantgeek approved these changes

@super-harsh super-harsh super-harsh approved these changes

@davefellows davefellows Awaiting requested review from davefellows davefellows is a code owner

@babbageclunk babbageclunk Awaiting requested review from babbageclunk babbageclunk is a code owner

Assignees

@matthchr matthchr

Labels
None yet
Projects
Azure Service Operator Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support for additional L-Series compute resources
4 participants
@matthchr @codecov-commenter @theunrepentantgeek @super-harsh