Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional AzureSqlServer controller messages #362

Merged
merged 5 commits into from
Oct 16, 2019
Merged

Additional AzureSqlServer controller messages #362

merged 5 commits into from
Oct 16, 2019

Conversation

melonrush13
Copy link
Contributor

@melonrush13 melonrush13 commented Oct 15, 2019

**What this PR does / why we need it:**

Adding additional messages now that more code has been merged.
Including:

  • Invalid Server Name
  • Failed to Delete
  • Failed to add Finalizer
  • Ignorable Error Types

Doggo

Note: PR 356 also adds messages to this file which is why some aren't included.

Running the PR

Example: Testing Invalid Server Name.
Create an invalid server name (Ex: sqlserver1.2) and do a k get status. Should get the following under status:

status: message: 'CreateOrUpdateSQLServer not complete: sql.ServersClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="InvalidServerName" Message="Server name ''sqlserver-sample-testerooni1.1'' cannot be empty or null. It can only be made up of lowercase letters ''a''-''z'', the numbers 0-9 and the hyphen. The hyphen may not lead or trail in the name."' provisioning: true state: NotReady

Special notes for your reviewer:
Please let me know if there are other messages we need to add here. Going to add SqlFirewallRule and additional controllers based off of this one.
If applicable:

@melonrush13
Copy link
Contributor Author

Was having issues adding to this branch ( after doing a reclone due to the version change. )
This was the old PR for this: #133

@melonrush13 melonrush13 merged commit 242b732 into Azure:master Oct 16, 2019
Porges pushed a commit that referenced this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants