Update Managed Cluster to v2023-07-01 #3629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
matthchr,
babbageclunk and
super-harsh
as code owners
super-harsh
reviewed
Dec 5, 2023
| } | ||
|
|
||
| func NewManagedCluster20230701(tc *testcommon.KubePerTestContext, rg *v1api20200601.ResourceGroup, adminUsername string, sshPublicKey *string) *aks.ManagedCluster { | ||
| region := to.Ptr("westus3") // TODO: the default test region of westus2 doesn't allow ds2_v2 at the moment |
There was a problem hiding this comment.
can move this to Location with comment?
There was a problem hiding this comment.
and remove //region := tc.AzureRegion
There was a problem hiding this comment.
When a test can't be run in the standard test region, this is how we normally move it, so that every resource gets the same region (if there are more than one).
| @@ -0,0 +1,13 @@ | |||
| apiVersion: storage.azure.com/v1api20210401 | |||
| kind: StorageAccount | |||
There was a problem hiding this comment.
Don't think this ref and below (Workspaces, Keyvault) are used in containerservice samples?
There was a problem hiding this comment.
I've simplified the samples.
matthchr
previously approved these changes
Dec 5, 2023
v2/api/containerservice/customizations/managed_clusters_agent_pool_extensions.go
Outdated
Show resolved
Hide resolved
| @@ -17,7 +17,7 @@ import ( | |||
| "sigs.k8s.io/controller-runtime/pkg/client" | |||
| "sigs.k8s.io/controller-runtime/pkg/conversion" | |||
|
|
|||
| containerservice "github.com/Azure/azure-service-operator/v2/api/containerservice/v1api20230201/storage" | |||
| containerservice "github.com/Azure/azure-service-operator/v2/api/containerservice/v1api20230701/storage" | |||
There was a problem hiding this comment.
Don't we need customized conversion for the property that disappeared and re-appeared? Where is it?
matthchr
reviewed
Dec 5, 2023
…ation' into feature/update-managed-cluster
matthchr
approved these changes
Dec 6, 2023
…zure/azure-service-operator into feature/update-managed-cluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Imports the latest stable version of
ManagedClusterandManagedClusterAgentPool, v2023-07-01.How does this PR make you feel:
If applicable: