Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure SQL local user #3701

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Azure SQL local user #3701

merged 1 commit into from
Jan 19, 2024

Conversation

matthchr
Copy link
Member

@matthchr matthchr commented Jan 13, 2024

This resolves #3001

If applicable:

  • this PR contains documentation
  • this PR contains tests
  • this PR contains YAML Samples

v2/test/azuresql_test.go Outdated Show resolved Hide resolved
v2/test/azuresql_test.go Outdated Show resolved Hide resolved
v2/internal/reconcilers/azuresql/connector.go Outdated Show resolved Hide resolved
v2/internal/reconcilers/azuresql/connector.go Outdated Show resolved Hide resolved
v2/internal/util/azuresql/azuresql.go Outdated Show resolved Hide resolved
v2/internal/util/azuresql/azuresql.go Outdated Show resolved Hide resolved
@matthchr matthchr force-pushed the feature/azure-sql-user branch from 5a840d5 to 24850c3 Compare January 19, 2024 18:20
@matthchr
Copy link
Member Author

/ok-to-test sha=24850c3

@codecov-commenter
Copy link

Codecov Report

Attention: 425 lines in your changes are missing coverage. Please review.

Comparison is base (75aa751) 53.57% compared to head (24850c3) 53.49%.
Report is 13 commits behind head on main.

Files Patch % Lines
v2/internal/util/azuresql/azuresql.go 0.00% 92 Missing ⚠️
v2/api/sql/v1/user_types.go 2.38% 82 Missing ⚠️
...l/reconcilers/azuresql/azuresql_user_reconciler.go 14.81% 69 Missing ⚠️
v2/internal/reconcilers/azuresql/local_user.go 0.00% 69 Missing ⚠️
v2/internal/util/azuresql/role.go 14.10% 67 Missing ⚠️
v2/internal/reconcilers/azuresql/connector.go 0.00% 29 Missing ⚠️
v2/internal/controllers/indexers.go 0.00% 10 Missing ⚠️
v2/internal/testcommon/kube_per_test_context.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3701      +/-   ##
==========================================
- Coverage   53.57%   53.49%   -0.09%     
==========================================
  Files        1409     1417       +8     
  Lines      483207   483927     +720     
==========================================
- Hits       258895   258891       -4     
- Misses     185114   185820     +706     
- Partials    39198    39216      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthchr matthchr added this pull request to the merge queue Jan 19, 2024
Merged via the queue into Azure:main with commit fd83ad8 Jan 19, 2024
9 checks passed
@matthchr matthchr deleted the feature/azure-sql-user branch January 19, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Feature: Support AzureSQL Database Users
4 participants