Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in asoctl #3862

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Fix panic in asoctl #3862

merged 1 commit into from
Mar 12, 2024

Conversation

matthchr
Copy link
Member

Caused by case-mismatch in Azure reported resource type.

If applicable:

  • this PR contains documentation
  • this PR contains tests
  • this PR contains YAML Samples

@matthchr matthchr added this to the v2.7.0 milestone Mar 12, 2024
@matthchr matthchr self-assigned this Mar 12, 2024
@matthchr matthchr added the bug 🪲 Something isn't working label Mar 12, 2024
Caused by case-mismatch in Azure reported resource type.
@matthchr matthchr force-pushed the feature/fix-asoctl-panic branch from 1c1fcfd to 935ff3a Compare March 12, 2024 00:52
@matthchr
Copy link
Member Author

/ok-to-test sha=935ff3a

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 53.47%. Comparing base (034c9e3) to head (935ff3a).
Report is 3 commits behind head on main.

Files Patch % Lines
...octl/internal/importing/importable_arm_resource.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3862      +/-   ##
==========================================
- Coverage   53.49%   53.47%   -0.02%     
==========================================
  Files        1521     1521              
  Lines      548770   548777       +7     
==========================================
- Hits       293538   293436     -102     
- Misses     209930   210036     +106     
- Partials    45302    45305       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthchr matthchr added this pull request to the merge queue Mar 12, 2024
Merged via the queue into Azure:main with commit c07de48 Mar 12, 2024
8 checks passed
@matthchr matthchr deleted the feature/fix-asoctl-panic branch March 12, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

3 participants