Modify Enum conversions to be case-insensitive/case-correcting #3880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
matthchr,
babbageclunk and
super-harsh
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3880 +/- ##
==========================================
+ Coverage 53.53% 53.70% +0.16%
==========================================
Files 1523 1525 +2
Lines 550082 552819 +2737
==========================================
+ Hits 294510 296878 +2368
- Misses 210035 210392 +357
- Partials 45537 45549 +12 ☔ View full report in Codecov by Sentry. |
matthchr
reviewed
Mar 20, 2024
v2/api/apimanagement/v1api20220801/api_version_set_types_gen.go
Outdated
Show resolved
Hide resolved
v2/api/apimanagement/v1api20220801/api_version_set_types_gen.go
Outdated
Show resolved
Hide resolved
v2/api/apimanagement/v1api20230501preview/storage/api_types_gen.go
Outdated
Show resolved
Hide resolved
matthchr
reviewed
Mar 20, 2024
theunrepentantgeek
force-pushed
the
feature/case-insensitive-enums
branch
from
22c04f4 to
c00fb31
Compare
theunrepentantgeek
force-pushed
the
feature/case-insensitive-enums
branch
from
c00fb31 to
b233fab
Compare
theunrepentantgeek
force-pushed
the
feature/case-insensitive-enums
branch
from
d3f7467 to
aa111dd
Compare
matthchr
approved these changes
Mar 22, 2024
|
|
||
| // ToEnum does a case-insensitive conversion of a string to an enum using a provided conversion map. | ||
| // If the required value is not found, a literal cast will be used to return the enum. | ||
| func ToEnum[T ~string](str string, enumMap map[string]T) T { |
There was a problem hiding this comment.
Yeah. Full credit though - you gave me the method signature. 😁
| @@ -298,6 +298,11 @@ type FakeResource_APIVersion_Spec string | |||
|
|
|||
| const FakeResource_APIVersion_Spec_20200601 = FakeResource_APIVersion_Spec("2020-06-01") | |||
|
|
|||
| // Mapping from string to FakeResource_APIVersion_Spec | |||
| var fakeResource_APIVersion_Spec_Values = map[string]FakeResource_APIVersion_Spec{ | |||
There was a problem hiding this comment.
Any idea why this apiversion in the test isn't getting excluded?
There was a problem hiding this comment.
Because the type isn't called exactly APIVersion - I'm guessing because the name isn't being simplified in the same way as the main pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In some cases information returned about a resource is is inconsistent with the letter casing specified in the OpenAPI specs for a resource - for example, the specs might specify
Succeededbut the service returnssucceeded.This PR modifies enum conversion to work in a case-insensitive way, which will case-correct values to conform with the OpenAPI specs.
Special notes for your reviewer:
The conversion from
statustospecused by asoctl will also pick up this fix.Closes #3805
How does this PR make you feel:
