Add namespace, label, and annotation support to asoctl #3884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
davefellows,
theunrepentantgeek,
babbageclunk and
super-harsh
as code owners
|
/ok-to-test sha=e4192d8 |
matthchr
force-pushed
the
feature/asoctl-namespaces-and-whatnot
branch
from
e4192d8 to
ca84263
Compare
|
/ok-to-test sha=ca84263 |
matthchr
force-pushed
the
feature/asoctl-namespaces-and-whatnot
branch
from
ca84263 to
1da4a91
Compare
|
/ok-to-test sha=1da4a91 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3884 +/- ##
==========================================
+ Coverage 53.53% 53.70% +0.17%
==========================================
Files 1523 1527 +4
Lines 550082 552896 +2814
==========================================
+ Hits 294462 296914 +2452
- Misses 210086 210426 +340
- Partials 45534 45556 +22 ☔ View full report in Codecov by Sentry. |
matthchr
force-pushed
the
feature/asoctl-namespaces-and-whatnot
branch
from
1da4a91 to
1e56092
Compare
matthchr
commented
Mar 24, 2024
|
/ok-to-test sha=1e56092 |
theunrepentantgeek
approved these changes
Mar 24, 2024
matthchr
force-pushed
the
feature/asoctl-namespaces-and-whatnot
branch
from
1e56092 to
a9d8aab
Compare
|
/ok-to-test sha=a9d8aab |
matthchr
force-pushed
the
feature/asoctl-namespaces-and-whatnot
branch
from
a9d8aab to
8414dc3
Compare
|
/ok-to-test sha=8414dc3 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3865
If applicable: