Add best practices documentation and update other docs #3938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
davefellows,
theunrepentantgeek,
babbageclunk and
super-harsh
as code owners
super-harsh
approved these changes
Apr 14, 2024
| --set crdPattern=resources.azure.com/*;containerservice.azure.com/*;keyvault.azure.com/*;managedidentity.azure.com/*;eventhub.azure.com/* | ||
| ``` | ||
| {{% /tab %}} | ||
| {{% tab header="CMD" %}} |
There was a problem hiding this comment.
Why remove CMD? We know we have users using this.
You could say "Create a file with the following content, and then apply it as follows" or similar.
There was a problem hiding this comment.
The problem is the file needs the env variables embedded in it... maybe I can write a multiline cmd that creates the file using the env variables... though not 100% sure how to do that without EOF
There was a problem hiding this comment.
Show a sample with placeholders and give them an instruction to replace the values?
matthchr
force-pushed
the
feature/more-docs
branch
from
5350421 to
695a8a0
Compare
|
/ok-to-test sha=695a8a0 |
theunrepentantgeek
approved these changes
Apr 16, 2024
* Added general and security best practices sections. * Updated FAQ to discuss CVE patching. * Moved to use more visible warnings/notes in ASOv1 -> ASOv2 migration guide. This fixes Azure#3261.
matthchr
force-pushed
the
feature/more-docs
branch
from
695a8a0 to
f56ca7b
Compare
|
/ok-to-test sha=f56ca7b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
guide.
This fixes #3261.
If applicable: