Update InitializeSpec to use enumeration conversions and maintain letter case #4109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
matthchr,
babbageclunk and
super-harsh
as code owners
matthchr
approved these changes
Jun 18, 2024
...estGolden_PropertyAssignmentFunction_AsFunc/ConvertBetweenRequiredEnumAndRequiredEnum.golden
Show resolved
Hide resolved
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The case-correcting conversions previously introduced weren't being used for the Status->Spec conversion required by
asoctl, resulting in the generated YAML files containing the incorrect values (which is an issue given Kubernetes validation is case-strict, not case-forgiving).We update the property conversions to handle the new case and regenerate the api files.
Special notes for your reviewer:
Closes #3805
How does this PR make you feel:
If applicable: