Allow custom OperatorSpec properties to be defined in configuration #4175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
matthchr,
babbageclunk and
super-harsh
as code owners
matthchr
reviewed
Aug 15, 2024
...internal/config/testdata/TestTypeConfiguration/WhenYAMLWellFormed_ReturnsExpectedResult.yaml
Show resolved
Hide resolved
theunrepentantgeek
force-pushed
the
feature/operatorspec-properties
branch
from
6adb1ab
to
ddacb2f
Compare
matthchr
approved these changes
Aug 16, 2024
theunrepentantgeek
force-pushed
the
feature/operatorspec-properties
branch
from
0586356
to
3b58c72
Compare
theunrepentantgeek
force-pushed
the
feature/operatorspec-properties
branch
from
3b58c72
to
e1da624
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allows custom OperatorSpec properties to be defined in our configuration file, as decided in our recent ADR.
This came out simpler than expected. 😁
Special notes for your reviewer:
This PR includes a demo, creating the property
NamingConventionfor RoleAssignment. This can easily be dropped out if we don't want it.How does this PR make you feel:
If applicable: