Fix BackupVaults/BackupInstance extension to exit early on terminal states #4180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
super-harsh
requested review from
davefellows,
theunrepentantgeek,
matthchr and
babbageclunk
as code owners
matthchr
reviewed
Aug 7, 2024
| "github.com/Azure/azure-service-operator/v2/internal/util/to" | ||
| "github.com/Azure/azure-service-operator/v2/pkg/genruntime" | ||
| "github.com/Azure/azure-service-operator/v2/pkg/genruntime/extensions" | ||
| ) | ||
|
|
||
| var _ extensions.PostReconciliationChecker = &BackupVaultsBackupInstanceExtension{} | ||
|
|
||
| var protectionError = "ProtectionError" | ||
| var terminalStates = set.Make( |
There was a problem hiding this comment.
Can you add some documentation about how we determined this list, and what exactly it means to be terminal here?
There was a problem hiding this comment.
These are the states listed and we do no foresee any frequent changed here as these states are not usually changed.
Public Doc: (might not be updated with latest swagger)
https://learn.microsoft.com/en-us/rest/api/dataprotection/backup-instances/get?view=rest-dataprotection-2024-04-01&tabs=HTTP#status
There was a problem hiding this comment.
Adding these URLs as comments would be useful, so that a future maintainer can go verify if things change in the future.
v2/api/dataprotection/customizations/backup_vaults_backup_instance_extensions.go
Show resolved
Hide resolved
v2/api/dataprotection/customizations/backup_vaults_backup_instance_extensions.go
Outdated
Show resolved
Hide resolved
matthchr
reviewed
Aug 13, 2024
v2/internal/controllers/crd_dataprotection_backupinstance_20231101_test.go
Show resolved
Hide resolved
theunrepentantgeek
approved these changes
Aug 14, 2024
matthchr
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4135
What this PR does / why we need it:
Fix BackupVaults/BackupInstance extension to exit early on terminal states. Most of the changes are reverted from commit which introduced the bug.