Upgrade controller logging #4222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
matthchr,
babbageclunk and
super-harsh
as code owners
theunrepentantgeek
force-pushed
the
feature/upgrade-logging
branch
from
eec2428 to
708be68
Compare
matthchr
reviewed
Aug 28, 2024
matthchr
approved these changes
Aug 30, 2024
matthchr
reviewed
Aug 30, 2024
theunrepentantgeek
force-pushed
the
feature/upgrade-logging
branch
from
a90d788 to
cee2185
Compare
theunrepentantgeek
force-pushed
the
feature/upgrade-logging
branch
from
cee2185 to
b0aae16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Refactors the startup of our controller to separate log initialization from app initialization.
Removes use of the deprecated
klogrlibrary in favour oftextlogger.Introduces the new commandline flag
--json-loggingwhich switches the output in the obvious way.Special notes for your reviewer
The package
k8s.io/klog/v2/klogris deprecated in favour ofk8s.io/klog/v2/textloggerso we need to switch to that.Closes #4191
Adding JSON logging as an option (by specifying
--json-loggingon the command line) enables better integration with structured logging tools.Closes #1620
By using
zapfor JSON formatted logging, we get stack traces included in the logs by default.Closes #3529
Testing
Tested manually on the command line.
How does this PR make you feel