Add support for ApplicationGatewayWebApplicationFirewallPolicies #4238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
davefellows,
theunrepentantgeek,
babbageclunk and
super-harsh
as code owners
matthchr
commented
Sep 3, 2024
|
|
||
| var _ extensions.ErrorClassifier = &BastionHostExtension{} | ||
|
|
||
| func (extension *BastionHostExtension) ClassifyError( |
There was a problem hiding this comment.
Found these during recording, so just fixed inline.
|
/ok-to-test sha=5f577bc |
matthchr
force-pushed
the
feature/app-gateway-wafp
branch
from
5f577bc
to
c829bf6
Compare
|
/ok-to-test sha=c829bf6 |
1 similar comment
|
/ok-to-test sha=c829bf6 |
matthchr
commented
Sep 3, 2024
| @@ -0,0 +1,31 @@ | |||
| apiVersion: network.azure.com/v1api20240101 | |||
| kind: WebApplicationFirewallPolicy | |||
There was a problem hiding this comment.
This is a weird place for this resource sample, my plan is to create new versions of all of the networking resources and then I'll move this sample to a 2024 folder
There was a problem hiding this comment.
Will do that in a separate PR though
theunrepentantgeek
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4119.
If applicable: