Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for KubernetesConfiguration/FluxConfiguration #4275

Merged
merged 9 commits into from
Oct 14, 2024

Conversation

super-harsh
Copy link
Collaborator

Closes #2312

What this PR does / why we need it:
Add new resource Microsoft.KubernetesConfiguration/FluxConfiguration.

If applicable:

  • this PR contains documentation
  • this PR contains tests
  • this PR contains YAML Samples

│ ├── AzureBlob: *Object (9 properties)
│ │ ├── AccountKey: *genruntime.SecretReference
│ │ ├── ContainerName: *string
│ │ ├── LocalAuthRef: *string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea what this is, and if it's a secret?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the "Name of a local secret on the Kubernetes cluster to use as the authentication secret rather than the managed or user-provided configuration secrets."

│ ├── GitRepository: *Object (8 properties)
│ │ ├── HttpsCACert: *genruntime.SecretReference
│ │ ├── HttpsUser: *string
│ │ ├── LocalAuthRef: *string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question here

│ │ ├── "Bucket"
│ │ └── "GitRepository"
│ ├── Suspend: *bool
│ ├── SystemData: *Object (6 properties)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just prune this from the spec.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

tc := globalTestContext.ForTest(t)
rg := tc.CreateTestResourceGroupAndWait()

adminUsername := "adminUser"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not the most important topic in this PR, so feel free to ignore it or maybe we should file a separate test improvement issue, but I think you can create AKS clusters without SSH access, and just specify managedIdentity intead.

Feels cleaner for these cases where don't actually care about SSH access?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good idea, although bit torn on if it's worth spending time to get it replaced with MI and re-record the tests?
Since it's just a CRUD test for a resource and we have random generated passwords safe.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just file a low-priority issue for it?

@super-harsh super-harsh added this pull request to the merge queue Oct 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 2, 2024
@super-harsh super-harsh enabled auto-merge October 7, 2024 15:37
@super-harsh super-harsh added this pull request to the merge queue Oct 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 7, 2024
@super-harsh super-harsh added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit 59832d8 Oct 14, 2024
8 checks passed
@super-harsh super-harsh deleted the feature/flux-configuration branch October 14, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Feature: Support for KubernetesConfiguration/fluxConfigurations
2 participants