Add support for v1api20230801/Cache.Redis #4287
Conversation
super-harsh
requested review from
davefellows,
theunrepentantgeek,
matthchr and
babbageclunk
as code owners
| - HostName | ||
| - Port | ||
| - SSLPort | ||
| RedisCreateProperties: |
There was a problem hiding this comment.
This is commented out in the other API versions? Do you know why?
There was a problem hiding this comment.
Not sure, but generator forced on this prop to be added it in this time. Although looks like the shape looks the same in older API versions too.
| - HostName | ||
| - Port | ||
| - SSLPort | ||
| RedisCreateProperties: |
There was a problem hiding this comment.
This is commented out in the other API versions? Do you know why?
There was a problem hiding this comment.
Not sure, but generator forced on this prop to be added it in this time. Although looks like the shape looks the same in older API versions too.
| "github.com/Azure/azure-service-operator/v2/pkg/genruntime" | ||
| ) | ||
|
|
||
| func Test_Cache_Redis_20230801_CRUD(t *testing.T) { |
There was a problem hiding this comment.
Since we're adding this test, wondering if we should remove the test and recordings for Test_Cache_Redis_20201201_CRUD, since it's old and IIRC we decided to only keep around ~2 GA versions and ~1 preview version tests?
Closes #4231
What this PR does / why we need it:
This PR adds support for 20230801 version of Cache.Redis resources
Special notes for your reviewer:
Also have moved samples to their respective version folders
If applicable: