Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry if/when ScheduledQueryRules encounter BadRequest #4312

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

theunrepentantgeek
Copy link
Member

What this PR does

When reconciling an Insights ScheduledQueryRule, we can get a BadRequest response if the associated Log Analytics Workspace doesn't yet exist; we need to reclassify that as a retryable error.

Closes #4293

How does this PR make you feel

gif

@theunrepentantgeek theunrepentantgeek added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 616a82c Oct 1, 2024
7 checks passed
@theunrepentantgeek theunrepentantgeek deleted the feature/retryable-schedule-query-rules branch October 1, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Bug: Controller doesn't requeue ScheduledQueryRules
2 participants