Feature/application security group #4342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishant221
requested review from
davefellows,
theunrepentantgeek,
matthchr,
babbageclunk and
super-harsh
as code owners
|
@microsoft-github-policy-service agree company="Adobe" |
nishant221
force-pushed
the
feature/application_security_group
branch
from
6354a6a to
92e6d8d
Compare
You didn't need to run those tasks - we have them scheduled to run as required. No problem though. 😄 |
theunrepentantgeek
approved these changes
Oct 15, 2024
Comment on lines
+25
to
+31
| // nsg := &network.NetworkSecurityGroup{ | ||
| // ObjectMeta: tc.MakeObjectMetaWithName(tc.Namer.GenerateName("asg")), | ||
| // Spec: network.NetworkSecurityGroup_Spec{ | ||
| // Location: tc.AzureRegion, | ||
| // Owner: testcommon.AsOwner(rg), | ||
| // }, | ||
| // } |
There was a problem hiding this comment.
If you don't need this nsg, delete this code.
matthchr
approved these changes
Oct 15, 2024
|
/ok-to-test sha=635dd30 |
nishant221
force-pushed
the
feature/application_security_group
branch
from
635dd30 to
ada6772
Compare
|
/ok-to-run sha=ada6772 |
|
/ok-to-test sha=ada6772 |
|
Thanks @nishant221 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4291
What this PR does / why we need it:
Add new resource Microsoft.Network/ApplicationSecurityGroup
Special notes for your reviewer:
Few additional files are generated inside
docs/hugo/content/when I ran tasks "doc:crd-api" & "doc:render-diagrams"How does this PR make you feel: Excited :)
If applicable: