Bug: Found an issue with Azure SQL Server where it doesnt recognize existing SQL servers #782

WilliamMortlMicrosoft · 2020-03-17T20:12:51Z

closes #783

The Azure SQL Server operator should detect if a SQL server exists in the selected resource group and then complete reconciliation. The code was blocking that functionality. This bug fix addresses that issue.

To test:

create new SQL servers from scratch (that works with out issue)
create a SQL server in the portal and then configure your YAML to point to that SQL server - it should reconcile almost immediately

PR merge

Merging master changes

Telemetry Enhancement PR (#683)

pr

PR

pr

PR

pr

WilliamMortlMicrosoft · 2020-03-17T20:13:37Z

pkg/resourcemanager/azuresql/azuresqlserver/azuresqlserver_reconcile.go

@@ -106,22 +106,21 @@ func (s *AzureSqlServerManager) Ensure(ctx context.Context, obj runtime.Object,
 		instance.Status.SpecHash = hash
 	}

-	if instance.Status.Provisioning {


this line was blocking the reconciler from "attaching" to existing SQL Servers - that was the desired functionality at one time, is it not anymore @jananivMS ?

@frodopwns fixed this as part of his PR here - #741 and I tested this. This scenario worked fine, so wondering what was the scenario that you saw the failure in, @WilliamMortlMicrosoft ? Status.Message would tell you if this reconcile doesnt happen. One of the cases where this happens is if the SQL server is present but the secret is not present in kube/keyvault. This is because we dont know the admin creds of an existing server and for it to work correctly we need to have the person externally creating the SQL server to also populate the secret.

frodopwns · 2020-03-17T22:56:46Z

The scenario #2 only works if you create a secret with the username and password for the sql server you created manually.

Also, when you say "update your yaml" are you talking about patching the first sql server you created or changing the yaml and then deploying a new server?

WilliamMortlMicrosoft · 2020-03-18T15:47:45Z

/azp run

azure-pipelines · 2020-03-18T15:47:56Z

Azure Pipelines successfully started running 1 pipeline(s).

WilliamMortlMicrosoft · 2020-03-18T15:50:24Z

The scenario #2 only works if you create a secret with the username and password for the sql server you created manually.

Also, when you say "update your yaml" are you talking about patching the first sql server you created or changing the yaml and then deploying a new server?

What SQL server wasn't doing is recognizing that server existed... This used to be an important criteria... happy to pull the PR @frodopwns if you think it isnt needed

frodopwns · 2020-03-18T15:53:53Z

@WilliamMortlMicrosoft reviewer should just verify they can repro

jananivMS · 2020-03-18T16:01:57Z

@WilliamMortlMicrosoft is this on master? I can give this a try as I did the testing for the different scenarios in Erin’s PR and see if it reproduces and then work with you on if we need this PR.

frodopwns · 2020-03-18T17:53:29Z

@WilliamMortlMicrosoft Is this basically what you were seeing?

2020-03-18T11:51:20.516-0600	DEBUG	controller-runtime.controller	Successfully Reconciled	{"controller": "azuresqlserver", "request": "default/sqlserver-reprobugziller"}
2020-03-18T11:51:20.516-0600	INFO	controllers.AzureSqlServer	reconciling object	{"Info Type": "status", "Component": "AzureSqlServer", "Instance": "default/sqlserver-reprobugziller"}
2020-03-18T11:51:24.279-0600	INFO	controllers.AzureSqlServer	reconciling object not finished	{"Info Type": "status", "Component": "AzureSqlServer", "Instance": "default/sqlserver-reprobugziller"}
2020-03-18T11:51:24.279-0600	INFO	controllers.AzureSqlServer	exiting reconciliation	{"Info Type": "status", "Component": "AzureSqlServer", "Instance": ""}
2020-03-18T11:51:24.279-0600	INFO	controllers.AzureSqlServer	reconciling object	{"Info Type": "status", "Component": "AzureSqlServer", "Instance": "default/sqlserver-reprobugziller"}
2020-03-18T11:51:26.647-0600	INFO	controllers.AzureSqlServer	reconciling object not finished	{"Info Type": "status", "Component": "AzureSqlServer", "Instance": "default/sqlserver-reprobugziller"}
2020-03-18T11:51:26.647-0600	INFO	controllers.AzureSqlServer	exiting reconciliation	{"Info Type": "status", "Component": "AzureSqlServer", "Instance": ""}
2020-03-18T11:51:44.280-0600	INFO	controllers.AzureSqlServer	reconciling object	{"Info Type": "status", "Component": "AzureSqlServer", "Instance": "default/sqlserver-reprobugziller"}
2020-03-18T11:51:46.699-0600	INFO	controllers.AzureSqlServer	reconciling object not finished	{"Info Type": "status", "Component": "AzureSqlServer", "Instance": "default/sqlserver-reprobugziller"}
2020-03-18T11:51:46.699-0600	INFO	controllers.AzureSqlServer	exiting reconciliation	{"Info Type": "status", "Component": "AzureSqlServer", "Instance": ""}

status:
  message: "SQL server already exists and the credentials could not be found. \n\t\t\t\tIf
    using kube secrets a secret should exist at 'default/sqlserver-reprobugziller'
    for keyvault it should be 'default-sqlserver-reprobugziller'"

WilliamMortlMicrosoft · 2020-03-18T17:58:18Z

@WilliamMortlMicrosoft Is this basically what you were seeing?

2020-03-18T11:51:20.516-0600	DEBUG	controller-runtime.controller	Successfully Reconciled	{"controller": "azuresqlserver", "request": "default/sqlserver-reprobugziller"}
2020-03-18T11:51:20.516-0600	INFO	controllers.AzureSqlServer	reconciling object	{"Info Type": "status", "Component": "AzureSqlServer", "Instance": "default/sqlserver-reprobugziller"}
2020-03-18T11:51:24.279-0600	INFO	controllers.AzureSqlServer	reconciling object not finished	{"Info Type": "status", "Component": "AzureSqlServer", "Instance": "default/sqlserver-reprobugziller"}
2020-03-18T11:51:24.279-0600	INFO	controllers.AzureSqlServer	exiting reconciliation	{"Info Type": "status", "Component": "AzureSqlServer", "Instance": ""}
2020-03-18T11:51:24.279-0600	INFO	controllers.AzureSqlServer	reconciling object	{"Info Type": "status", "Component": "AzureSqlServer", "Instance": "default/sqlserver-reprobugziller"}
2020-03-18T11:51:26.647-0600	INFO	controllers.AzureSqlServer	reconciling object not finished	{"Info Type": "status", "Component": "AzureSqlServer", "Instance": "default/sqlserver-reprobugziller"}
2020-03-18T11:51:26.647-0600	INFO	controllers.AzureSqlServer	exiting reconciliation	{"Info Type": "status", "Component": "AzureSqlServer", "Instance": ""}
2020-03-18T11:51:44.280-0600	INFO	controllers.AzureSqlServer	reconciling object	{"Info Type": "status", "Component": "AzureSqlServer", "Instance": "default/sqlserver-reprobugziller"}
2020-03-18T11:51:46.699-0600	INFO	controllers.AzureSqlServer	reconciling object not finished	{"Info Type": "status", "Component": "AzureSqlServer", "Instance": "default/sqlserver-reprobugziller"}
2020-03-18T11:51:46.699-0600	INFO	controllers.AzureSqlServer	exiting reconciliation	{"Info Type": "status", "Component": "AzureSqlServer", "Instance": ""}

status:
  message: "SQL server already exists and the credentials could not be found. \n\t\t\t\tIf
    using kube secrets a secret should exist at 'default/sqlserver-reprobugziller'
    for keyvault it should be 'default-sqlserver-reprobugziller'"

yes

WilliamMortlMicrosoft · 2020-03-18T17:58:49Z

@jananivMS said working as expected - so closing the PR

WilliamMortlMicrosoft and others added 13 commits March 2, 2020 21:37

Merge pull request #1 from Azure/master

2ecb9dc

PR merge

Merge pull request #2 from Azure/master

1044fa6

Merging master changes

Merge pull request #3 from Azure/master

f6ad679

Telemetry Enhancement PR (#683)

Merge pull request #4 from Azure/master

31a05f9

pr

Merge pull request #5 from Azure/master

a242cc4

PR

Merge pull request #6 from Azure/master

80d1f6f

pr

Merge pull request #7 from Azure/master

8521de1

pr

Merge pull request #8 from Azure/master

9e64e35

PR

Merge pull request #9 from Azure/master

f692791

PR

Merge pull request #10 from Azure/master

ad8c37c

PR

Merge pull request #11 from Azure/master

0219bd9

PR

Merge pull request #12 from Azure/master

535b64c

pr

first

608294d

WilliamMortlMicrosoft added bug 🪲 Something isn't working azure-sql high-priority Issues we intend to prioritize (security, outage, blocking bug) labels Mar 17, 2020

WilliamMortlMicrosoft self-assigned this Mar 17, 2020

WilliamMortlMicrosoft commented Mar 17, 2020

View reviewed changes

WilliamMortlMicrosoft requested review from jananivMS and jskulavik March 17, 2020 20:14

jananivMS requested review from frodopwns and removed request for jskulavik and jananivMS March 17, 2020 22:44

Merge branch 'master' into deleteFix

a622613

Merge branch 'master' into deleteFix

34d46b1

WilliamMortlMicrosoft closed this Mar 18, 2020

WilliamMortlMicrosoft deleted the deleteFix branch March 18, 2020 17:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug: Found an issue with Azure SQL Server where it doesnt recognize existing SQL servers #782

Bug: Found an issue with Azure SQL Server where it doesnt recognize existing SQL servers #782

WilliamMortlMicrosoft commented Mar 17, 2020 •

edited

Loading

WilliamMortlMicrosoft Mar 17, 2020

jananivMS Mar 17, 2020 •

edited

Loading

frodopwns commented Mar 17, 2020

WilliamMortlMicrosoft commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

WilliamMortlMicrosoft commented Mar 18, 2020

frodopwns commented Mar 18, 2020

jananivMS commented Mar 18, 2020

frodopwns commented Mar 18, 2020

WilliamMortlMicrosoft commented Mar 18, 2020

WilliamMortlMicrosoft commented Mar 18, 2020

Bug: Found an issue with Azure SQL Server where it doesnt recognize existing SQL servers #782

Bug: Found an issue with Azure SQL Server where it doesnt recognize existing SQL servers #782

Conversation

WilliamMortlMicrosoft commented Mar 17, 2020 • edited Loading

WilliamMortlMicrosoft Mar 17, 2020

Choose a reason for hiding this comment

jananivMS Mar 17, 2020 • edited Loading

Choose a reason for hiding this comment

frodopwns commented Mar 17, 2020

WilliamMortlMicrosoft commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

WilliamMortlMicrosoft commented Mar 18, 2020

frodopwns commented Mar 18, 2020

jananivMS commented Mar 18, 2020

frodopwns commented Mar 18, 2020

WilliamMortlMicrosoft commented Mar 18, 2020

WilliamMortlMicrosoft commented Mar 18, 2020

WilliamMortlMicrosoft commented Mar 17, 2020 •

edited

Loading

jananivMS Mar 17, 2020 •

edited

Loading