Kevault: Add Get/Delete functionality for flattened keys & implement … #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jananivMS
suggested changes
Apr 1, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implements Get/Delete functionality for flattened keys (and fixes a couple bugs in Get/Delete for regular keys). Prior PR's only included bare-minimum write functionality for the Azure SQL User use-case where the keys were used by external tools.
Creates a reusable keyvault in the test suite to test all components that rely on it. The Eventhub test has been migrated to use the master kv and the AzureSQLTests now use it for keyvault-specific functionality. This also required increasing the test setup timeout by 1min to give the KV time to start up.
Adds the Keyvault Client test suite to the makefile test suite. It was already written but was missing in the path/module list.
Fixes #751
** Suggested Review Steps**:
Run the controller test suite to confirm pass:
make BUILD_TAG=azuresqlservercombined test-existing-controllersManually break the keyvault code in the azuresqlsqluser controller or pkg/secrets keyvault client, re-run tests and confirm failure.
How does this PR make you feel:
If applicable: