Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow redis cache to be deployed into a vnet #816

Merged
merged 16 commits into from
Mar 30, 2020
Merged

allow redis cache to be deployed into a vnet #816

merged 16 commits into from
Mar 30, 2020

Conversation

frodopwns
Copy link
Contributor

@frodopwns frodopwns commented Mar 24, 2020 •
edited
Loading

closes #797

What this PR does / why we need it:
exposes the fields necessary to put redis in a vnet

To test:

  • create resource group
  • create virtual network in rg
  • set subnet id and an ip from within the vnet subnet range
  • deployment should succeed and the portal should show that it is in a vnet

@frodopwns frodopwns changed the title WIP: allow redis cache to be deployed into a vnet allow redis cache to be deployed into a vnet Mar 25, 2020
@frodopwns frodopwns requested a review from jananivMS March 25, 2020 17:21
jananivMS
jananivMS reviewed Mar 26, 2020
View reviewed changes
Copy link
Contributor

@jananivMS jananivMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this now. But adding the comments before that in case you want to take a look.

config/samples/azure_v1alpha1_rediscache.yaml Show resolved Hide resolved
api/v1alpha1/rediscache_types.go Outdated Show resolved Hide resolved
config/samples/azure_v1alpha1_rediscache.yaml Outdated Show resolved Hide resolved
pkg/resourcemanager/rediscaches/rediscache_reconcile.go Show resolved Hide resolved
pkg/resourcemanager/rediscaches/rediscaches.go Show resolved Hide resolved
pkg/resourcemanager/rediscaches/rediscaches.go Show resolved Hide resolved
pkg/resourcemanager/rediscaches/rediscaches.go Show resolved Hide resolved
jananivMS
jananivMS previously requested changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@jananivMS jananivMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some errors in testing that we might need to catch. But otherwise tested with the redis configuration values too and things work well

@jananivMS jananivMS dismissed their stale review March 30, 2020 15:47

changes updated and so re-reviewing

jananivMS
jananivMS approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@jananivMS jananivMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and verified.

@frodopwns frodopwns merged commit e228fea into Azure:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jananivMS jananivMS jananivMS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task: Rediscahe: VNET support
3 participants
@frodopwns @jananivMS @WilliamMortlMicrosoft